[system] CSSVarsProvider cleans up html[style] when unmounting
#29946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
eps1lon
changed the title
html[style] when unmounting
eps1lon
force-pushed
the
fix/system/cleanup
branch
from
c15b037 to
46e653c
Compare
eps1lon
force-pushed
the
fix/system/cleanup
branch
from
46e653c to
85de16e
Compare
eps1lon
commented
Nov 29, 2021
| @@ -141,14 +141,19 @@ export default function createCssVarsProvider(options) { | |||
|
|
|||
| React.useEffect(() => { | |||
There was a problem hiding this comment.
Aside: Pretty sure this should be a layout effect considering it does affect layout. @hbjORbj
There was a problem hiding this comment.
Oh, I see. Will make the change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #29929 (comment)
I adjusted the test descriptions since it sounded like the
bodyelement would be affected. However,document.documentElementpoints to<html>not<body>(that would bedocoument.body)Browser run: https://app.circleci.com/pipelines/github/mui-org/material-ui/57238/workflows/f8e8f5bb-04d8-4db2-990e-f7c0d7a2b75a